[packagers] nagios-plugins patch

Gavin Carr gavin at openfusion.com.au
Thu Dec 7 23:40:07 CET 2006


The current nagios-plugins package is missing the setuid plugins 
(check_icmp and check_dns at least) because the nagios-plugins guys
split them out into a separate install target, 'make install-root'.

The attached patch fixes the spec file to install with that target
as well.

Note that it doesn't make the plugins setuid. Is there any kind of
rpmforge policy on setuid binaries? If they're okay, what's the 
best way to make them setuid? A files section like:

%{_libdir}/nagios/plugins/
%attr(04755,root,root) %{_libdir}/nagios/plugins/check_icmp
%attr(04755,root,root) %{_libdir}/nagios/plugins/check_dns

and ignore the duplicate item warnings?

Cheers,
Gavin

-- 
Gavin Carr
Open Fusion - Open Source Business Solutions [ Linux - Perl - Apache ]
http://www.openfusion.com.au
- Fashion is a variable, but style is a constant - Programming Perl
-------------- next part --------------
--- nagios-plugins.spec.rf	2006-11-01 21:38:08.000000000 +1100
+++ nagios-plugins.spec	2006-12-08 09:17:06.000000000 +1100
@@ -17,7 +17,7 @@
 Summary: Host/service/network monitoring program plugins for Nagios
 Name: nagios-plugins
 Version: 1.4.4
-Release: 1.rf
+Release: 2.rf
 License: GPL
 Group: Applications/System
 URL: http://nagiosplug.sourceforge.net/
@@ -85,6 +85,7 @@
 %install
 %{__rm} -rf %{buildroot}
 %makeinstall
+make DESTDIR=%{buildroot} install-root
 %find_lang %{name}
 
 %{__install} -d -m0755 %{buildroot}%{_libdir}/nagios/plugins/contrib/
@@ -108,6 +109,9 @@
 %{perl_vendorlib}/utils.pm
 
 %changelog
+* Fri Dec 08 2006 Gavin Carr <gavin at openfusion.com.au> - 1.4.4-2
+- Added 'make install-root' to pickup setuid plugins (but not installed setuid).
+
 * Wed Nov 01 2006 Dag Wieers <dag at wieers.com> - 1.4.4-1 - 4481+/dries
 - Updated to release 1.4.4.
 - Fixed the problem where --with-pgsql defaults to 'yes'. (Jason Kim)


More information about the packagers mailing list